node-export-server icon indicating copy to clipboard operation
node-export-server copied to clipboard
verified publisher icon highcharts

v4 'cachePath' with absolute path

Open nhitchins opened this issue 1 year ago • 6 comments

Expected behaviour

highcharts.cachePath or HIGHCHARTS_CACHE_PATH env var should allow an absolute path such as '/tmp/.cache'

Actual behaviour

Previously (v3) if the manifest.json file existed in the 'node_modules/highcharts-export-server/.cache' directory but read-only it would log an error and initPool would continue to start. Now initExport throws an error.

Reproduction steps

Set the 'node_modules/highcharts-export-server/.cache/manifest.json' file as read-only and initExport will throw an error. Ideally just allow cachePath to specify an absolute path and if the manifest.json file exists (and un-changed) then skip writing new manifest

nhitchins avatar Aug 06 '24 04:08 nhitchins

All hardcoded paths should be configurable (with default values as fallbacks) in my opinion.

DanielRuf avatar Aug 07 '24 09:08 DanielRuf

@nhitchins @DanielRuf feel free to test out #576 and let me know if absolute path for the Highcharts cache works as expected now.

jszuminski avatar Sep 02 '24 10:09 jszuminski

@jszuminski Working now with absolute path - confirmed!

nhitchins avatar Sep 02 '24 23:09 nhitchins

Great, thanks for the info! I will close this issue once we merge the PR.

jszuminski avatar Sep 03 '24 05:09 jszuminski

@jszuminski the PR has been merged for a while now, what are the plans to release the next version including this fix?

DKhalil avatar Dec 09 '24 16:12 DKhalil

So wait, the changes from the PR #576 have been reversed and put in another PR #597? What happened there? @cvasseng @PaulDalek

I really hoped I could finally use the export server with V5

DKhalil avatar Mar 25 '25 13:03 DKhalil