hack-router icon indicating copy to clipboard operation
hack-router copied to clipboard
verified publisher icon hhvm

Changed Hack Collections with Hack Arrays

Open CarusoX opened this issue 6 years ago • 4 comments

Replaced:

  • Vector, ImmVector with vec
  • Map, ImmMap with dict.

Updated the needed documentation on the README.

CarusoX avatar Apr 02 '20 23:04 CarusoX

I had to add the hsl-experimental prior version, since some project packages still need that version to work (due to the \Experimental\ being removed)

CarusoX avatar Apr 03 '20 01:04 CarusoX

The HHAST errors need a new release of HHAST with the new schema; you also need to adjust .travis.yml for the new minimum version

fredemmott avatar Apr 13 '20 23:04 fredemmott

Sorry for waking this PR from its slumber. This PR has merge conflicts.

Would you mind if I took your changes and redid this collection -> array migration? How would you like to be credited / get attribution for your work? Would you like a Co-authored by mention? This might imply you agree with my changes though, so that's why I felt I had to ask before doing so.

If you've moved on or are unable to reply for any reason, I'll use a with great thanks to CarusoX instead.

lexidor avatar May 25 '23 18:05 lexidor

Sound fine to me @lexidor! Thanks for the mention!

CarusoX avatar May 29 '23 11:05 CarusoX