hginit.github.io icon indicating copy to clipboard operation
hginit.github.io copied to clipboard

Responsive Design: Fix home navigation scroll

Open captn3m0 opened this issue 3 years ago • 5 comments

The scroll for the listing on the home page is not natural. It should instead be top-to-bottom on the homepage.

image

captn3m0 avatar Jan 24 '23 16:01 captn3m0

hello!, I'd love to work on this issue if it's still open and un-assigned. thanks

elidakirigo avatar Mar 06 '23 12:03 elidakirigo

Feel free to pick this up [^1]. My suggested solution would be to:

  1. Create vertical variants of all homenav images
  2. Write additional styles for devices with display width <1000px to switch the images to a vertical layout.

See this image for example:

homenav-vertical-1

We do have sources for the original images, but they happen to be in an ancient CPT 9 format, which I can't open.

[^1]: General advice, for small issues like these is to avoid comments "claiming" the issue, and just file a PR instead.

captn3m0 avatar Mar 07 '23 10:03 captn3m0

sure! i'll take a look

elidakirigo avatar Mar 07 '23 12:03 elidakirigo

Working on this for Hacktoberfest 2024!

jlduchaney avatar Oct 01 '24 15:10 jlduchaney

If you need any help with image conversions, do reach out.

captn3m0 avatar Oct 01 '24 17:10 captn3m0

Hi @captn3m0! Will you have time to review my pull requests before October 31?

If you don't have the bandwidth, I completely understand. I would just like to know if this is the case, so I can pick a different repository to work on for Hacktoberfest. Thanks in advance!

jlduchaney avatar Oct 15 '24 13:10 jlduchaney

Yes.

Since there's only single-digit pages in the entire repo, they are quite easy to review for breaking changes and correctness. As long as you take care to avoid breaking the site, should be easy to merge.

captn3m0 avatar Oct 15 '24 14:10 captn3m0

Thanks for the quick response. In that case, I'll continue working through the issues you've posted. Appreciate your time!

jlduchaney avatar Oct 15 '24 15:10 jlduchaney

Hi @captn3m0! I'm gently following up here. Please let me know if your availability has changed since your last comment. Thanks!

jlduchaney avatar Oct 29 '24 12:10 jlduchaney

If it's a small PR, I'll definitely review it within a day.

captn3m0 avatar Oct 29 '24 13:10 captn3m0

Thanks again for getting back to me so quickly. I have four open PRs, but they're all pretty small, so I don't think it should be a problem.

jlduchaney avatar Oct 29 '24 14:10 jlduchaney

Hi @captn3m0 ! Might you consider applying the "hacktoberfest-accepted" label to each of my four pull requests before end of day today? This way, they'll be eligible to qualify for Hacktoberfest even if you don't have time to merge them before midnight. Please let me know either way, and thanks again :blush:

jlduchaney avatar Oct 31 '24 12:10 jlduchaney

I've merged the two content PRs, and applied the label on the other two (#10, #11). The diff seemed okay, but I want to review them locally once before merging.

Thanks for your contributions 🥇!

captn3m0 avatar Oct 31 '24 17:10 captn3m0

Thanks for your quick response, as always! I'll set aside some time this weekend to figure out the .log files.

And thank you for being so welcoming. As someone who's still learning to code, having you as a maintainer made my first-ever Hacktoberfest a positive, approachable experience. I appreciate the work you're doing to keep hginit.com alive. Cheers!

jlduchaney avatar Oct 31 '24 17:10 jlduchaney

Hi, I would like to work on this issue. Could you assign it to me?

mantosh-mariner avatar Nov 30 '24 06:11 mantosh-mariner

This is closed already with #10, but you can try #14 - since the page contents are still pending.

captn3m0 avatar Nov 30 '24 13:11 captn3m0

Hi @captn3m0, could you confirm the repository link for this issue #14 ? I'd like to contribute. Thank you!

mantosh-mariner avatar Nov 30 '24 16:11 mantosh-mariner