piazza-api icon indicating copy to clipboard operation
piazza-api copied to clipboard

Avoid `f"..."` syntax

Open elibarzilay opened this issue 2 years ago • 2 comments

I don't know what's your policy for accommodating old versions, but the recent change broke this on older python (I'm using 3.4) because it doesn't have the f"..." syntax. If it's acceptable, then this switches it to plain strings which make it work again on that version.

elibarzilay avatar Sep 08 '23 06:09 elibarzilay

Just to clarify, I personally would rather use the new syntax, and arguably I should update my environment --- but since piazza is intended for universities, and department setups might be outdated, I thought that in this case it might be better to just avoid the new syntax to make it work better in such situations.

elibarzilay avatar Sep 08 '23 06:09 elibarzilay

This is fine, but I would still prefer we at least use str.format here (which should still be supported in 3.4) instead of string concatenation: https://docs.python.org/3.5/library/stdtypes.html#str.format

Can you make that update? Thanks.

hfaran avatar Sep 08 '23 13:09 hfaran