heytrav
Adding some try catch to various places that cause hard errors, espec…
Adding some try catch to various places that cause hard errors, especially for empty buffers; fixing issue with parseInt and listen port on command line not being set; fixed issue with namespaces from config not being correctly passed to the epp xml building code; nameservers are technically optional for createDomain; more try catch is necessary along with recovery for timeouts
The change to the way namespaces are passed is something I would like to have verified with other registries as it is currently breaking the tests. The current implementation worked fine when I used it in the past and no other users have reported issues with it (yet).
If indeed it is valid, then the tests should also be updated accordingly.
Otherwise, it looks ok to me. I would just like to see the tests passing before I merge.
The problem I noticed is that the previous code was not honoring the settings in the config.json, it was pretty much ignoring them or partially ignoring in the case of domain commands. I'll make the example config and tests match what the code had before outputting before, that way there is no change for the example and the tests, and then they should pass as before. Another pull request coming today.
On Sat, Nov 12, 2016 at 11:52 AM, William Travis Holton < [email protected]> wrote:
The change to the way namespaces are passed is something I would like to have verified with other registries as it is currently breaking the tests. The current implementation worked fine when I used it in the past and no other users have reported issues with it (yet).
If indeed it is valid, then the tests should also be updated accordingly.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/heytrav/nodepp/pull/10#issuecomment-260137414, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKssMNO2bb11DEEbN-KzyAX2BtwWeo-ks5q9fzsgaJpZM4Kvrij .
Christopher Schaub http://chris.schaub.com