openapi-ts icon indicating copy to clipboard operation
openapi-ts copied to clipboard

feat: add config to generate file extensions for module resolution no…

Open omridevk opened this issue 1 year ago • 10 comments

…de16+

omridevk avatar May 30 '24 07:05 omridevk

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

⚠️ No Changeset found

Latest commit: e6be2dc603920c0e45059886dd61fc81268ce00b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 30 '24 07:05 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 9:14am

vercel[bot] avatar May 30 '24 07:05 vercel[bot]

fixes: https://github.com/hey-api/openapi-ts/issues/478 and https://github.com/hey-api/openapi-ts/issues/595

omridevk avatar May 30 '24 07:05 omridevk

Hey, can you resolve the conflicts please? This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

mrlubos avatar May 30 '24 07:05 mrlubos

Hey, can you resolve the conflicts please? This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

yes, I do want to create a failing test based on the new config overrides.

Will resolve conflicts.

omridevk avatar May 30 '24 15:05 omridevk

@mrlubos Resolved the conflicts.

omridevk avatar Jun 09 '24 09:06 omridevk

This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

mrlubos avatar Jun 09 '24 10:06 mrlubos

Any updates on this issue? Recently, I started a new project with ESM and ran into this problem.

martinssonj avatar Aug 19 '24 14:08 martinssonj

@martinssonj We have been using this to resolve the issue in our build, couldn't find a time to fix this PR yet :( https://github.com/GervinFung/ts-add-js-extension

omridevk avatar Aug 20 '24 08:08 omridevk

Are there plans to pick up this PR? We would love to use this in some microservices, but it's a bit cumbersome to manually fix all the broken import statements.

florianbepunkt avatar Mar 04 '25 10:03 florianbepunkt

This will be (finally) added by https://github.com/hey-api/openapi-ts/pull/2003, please follow there for updates

mrlubos avatar May 02 '25 20:05 mrlubos