linkedin icon indicating copy to clipboard operation
linkedin copied to clipboard

Faraday connection updated

Open hundredwatt opened this issue 11 years ago • 7 comments

@hexgnu I came back and took another look at this. I rebased #212 onto master and made a few fixes. The only notable change is adding the :ignore_extra_keys which fixes SimpleOAuth v0.3.0.

How about targeting and #211 this for a 1.1.0 release? I'm going to work on #211 next

Also, I'm going to run this branch in one of our apps for a couple days to verify that its good to go.

Regarding #240, I'm happy to start reviewing the existing PRs and issues and enlisted some other developers here to help (@GaggleAMP) if necessary.

hundredwatt avatar Nov 12 '14 11:11 hundredwatt

@hexgnu I've been running this branch in a production app for a few days with no issues.

Only remaining problem is the build failing on rbx

hundredwatt avatar Nov 14 '14 14:11 hundredwatt

Maybe we should drop rbx support for right now unless someone pipes up?

hexgnu avatar Nov 18 '14 17:11 hexgnu

Agreed, if someone pipes up, then we can revisit

hundredwatt avatar Nov 19 '14 03:11 hundredwatt

@hexgnu Dropped rbx, good to merge?

hundredwatt avatar Nov 22 '14 19:11 hundredwatt

This will close #208

hundredwatt avatar Nov 22 '14 19:11 hundredwatt

The thread safe fix with Faraday works perfectly ! No more segmentation fault. Thx a lot !

solher avatar Nov 24 '14 11:11 solher

@Solher Good to hear!

hundredwatt avatar Nov 24 '14 14:11 hundredwatt