linkedin
linkedin copied to clipboard
Remove deletes
What
There is littered throughout the code a bunch of option.delete(:id) This is generally a bad idea and should go away for many reasons.
- Thread safety
- Why are we modifying the options that are being passed in this is silly
How to test
I put in a few extra tests but unfortunately I think that we need better tests around some of the weirder edge cases like the case where we don't want filter out things like id, email, name etc.
you looking for a :+1: here?
@brycemcd I put it up as a proof of concept though thinking that I should just merge it in.
Will close #181