linkedin icon indicating copy to clipboard operation
linkedin copied to clipboard

Remove deletes

Open hexgnu opened this issue 12 years ago • 3 comments

What

There is littered throughout the code a bunch of option.delete(:id) This is generally a bad idea and should go away for many reasons.

  1. Thread safety
  2. Why are we modifying the options that are being passed in this is silly

How to test

I put in a few extra tests but unfortunately I think that we need better tests around some of the weirder edge cases like the case where we don't want filter out things like id, email, name etc.

hexgnu avatar Nov 15 '13 19:11 hexgnu

you looking for a :+1: here?

brycemcd avatar Jan 29 '14 16:01 brycemcd

@brycemcd I put it up as a proof of concept though thinking that I should just merge it in.

hexgnu avatar Jan 29 '14 17:01 hexgnu

Will close #181

hundredwatt avatar Nov 22 '14 19:11 hundredwatt