Wrong naming "load-balancer.hetzner.cloud/http-redirect-http"

[IBims1ckoky]

TL;DR

I think this is wrong? The comment above says that this creates a redirect from http to https but the Annotation name is http-redirect-http?

https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/d746f122644242d5e42d611ce400be2b1c49328b/internal/annotation/load_balancer.go#L203-L207

Expected behavior

That the name is http-to-https.

Observed behavior

The name is http-to-http

Minimal working example

No response

Log output

Additional information

No response

[lukasmetzner]

Hey,

this was chosen due to the API request schema for adding a service to a Hetzner Cloud Load Balancer:

{
  "http": {
    "redirect_http": true
  }
}

I agree this is not ideal, but renaming this would be a breaking change. We already included this in our ideas for v2.0.0.