cli icon indicating copy to clipboard operation
cli copied to clipboard

fix(cli): Bring changes from 'main' for commands already migrated

Open sbosio opened this issue 1 year ago • 0 comments

Description

We didn't manage consistently the behavioral changes done to CLI commands in our main branch for commands that were already migrated to the prerelease branch for 9.x.

The verification procedure consisted of:

  • Generating a diff for command files between commits 8b7691b and our current main HEAD with git diff 8b7691b1a92c145ac83fdfa2e9f27d30dae78cda main packages/**/commands/ packages/**/**/commands/
  • Manually compare every file with diffs with their prerelease/9.0.0-alpha migrated command file to check if the changes were accounted for in the new version.
  • Make changes on files with non-migrated changes.

Diff file for reference: differences.patch

There weren't any major changes for current CLI commands and most of them were done prior to migration, except for the @heroku/heroku-cli-util package changed (that doesn't impact the prerelease branch), updates from got package (changes introduced here) and Larger Dynos feature (that was already migrated when importing changes from main on our weekly prerelease branch update). There are additional minor copy changes.

SOC2 Compliance

GUS Work Item

sbosio avatar May 10 '24 23:05 sbosio