oksse icon indicating copy to clipboard operation
oksse copied to clipboard

Library Version with HTTP2 support doesn't appear to be published on jitpack

Open fkurniaw opened this issue 5 years ago • 15 comments

When I bundle the oksse library as part of my android app, I get an issue where the list of protocols available is limited to only http/1.1

However, I've been explicitly passing in an OkHttpClient that has h2 as part of the protocols

Seems like the PR here isn't included in the library that was published to jitpack https://github.com/heremaps/oksse/pull/25

fkurniaw avatar Oct 18 '20 19:10 fkurniaw

This is a dead project. Use the SSE features built into okhttp as okhttp-sse.

lbdroid avatar Apr 13 '21 22:04 lbdroid

@lbdroid okhttp-sse does not reconnect - https://github.com/square/okhttp/issues/5471

vitalyster avatar Jun 27 '21 08:06 vitalyster

@vitalyster : Nothing stopping you from performing your own reconnect from onClosed() and onFailure().

lbdroid avatar Jun 28 '21 18:06 lbdroid

@lbdroid nothing stopping me writing my own library, but SSE support in okhttp-sse is broken and incomplete, while everything is ok in oksse

vitalyster avatar Jun 28 '21 18:06 vitalyster

Its not broken, and incomplete doesn't matter if it does what is needed. oksse is both broken and unsupported, which makes it a non-starter no matter how you look at it.

lbdroid avatar Jun 28 '21 18:06 lbdroid

@lbdroid automatic reconnection is a key feature of SSE standard, so okhttp-sse is broken(incomplete) and can not be used until the issue is not fixed

vitalyster avatar Jun 28 '21 18:06 vitalyster

Cry me a river. Its ONE LINE in your own code to make it automatically reconnect.

lbdroid avatar Jun 28 '21 18:06 lbdroid

Go and fix okhttp-sse then and stop that flood

vitalyster avatar Jun 28 '21 18:06 vitalyster

Why would I waste my time fixing something that doesn't need to be fixed?

lbdroid avatar Jun 28 '21 18:06 lbdroid

It should be fixed, because that library does not implement key feature of the standard it tries to implement

vitalyster avatar Jun 28 '21 18:06 vitalyster

What is your point? Are you advertising for this broken and unmaintained crap project?

lbdroid avatar Jun 28 '21 18:06 lbdroid

This project works perfectly and I'm pointing out key feature, while you are repeating FUD.

vitalyster avatar Jun 28 '21 18:06 vitalyster

This project hasn't seen a commit in 3 years. It does NOT work, and it uses a horrendously out of date and non-secure version of okhttp.

lbdroid avatar Jun 28 '21 18:06 lbdroid

It works absolutely correct and you can use any version of okhttp with it, learn how to manage dependencies before writing misinformation.

vitalyster avatar Jun 28 '21 18:06 vitalyster

Come back when you reach adulthood.

lbdroid avatar Jun 28 '21 18:06 lbdroid