Herb
If the function no longer exists, then it's not even deprecated. We shouldn't bring it back just so it can have a deprecated function. We've got a change record, that's...
I think the code looks fine. Doesn't look like it's stopping us from doing future abstraction if necessary. By the way, I was confused about the mention of testing with...
I think this is ready to merge. Code matches the D7 commit and it's been tested. I made fixes to the docblock.
Even though this is a "problem" I don't think it's a bug. Plus, the suggested changes are big enough that I'm more comfortable with this being in a minor release.
I think your idea is a good one @stpaultim but it does seem like a different idea from this issue. Yours is about having more of a "wizard" or generator...
Themes already store some things in config files (which you can't actually uninstall) so the basics are there. Maybe you could just build the array by calling config->get
@hosef do you want to weigh in on this? I think converting this to config makes sense. Would make color module more robust. Perhaps its possible to deal with this...
Good idea @hosef
Simple enough. I've tested and reviewed. RTBC