libpsf icon indicating copy to clipboard operation
libpsf copied to clipboard

Fix compilation error and invalid chunk bug for large simulation data

Open lekez2005 opened this issue 7 years ago • 4 comments

lekez2005 avatar Oct 26 '18 08:10 lekez2005

@lekez2005 thank you for your great work. I've been using your fork, and it works perfectly, except sometimes the code fails to parse some large transient files (~ 3GB). Do you know what the problem could be? I will try to upload one of the failed files if you are interested

yahia3200 avatar Oct 14 '24 12:10 yahia3200

@yahia3200 Feel free to upload a sample. I am currently unable to work on this due to time constraints but I can take a look the next time I have an opening. Hopefully in the next week or two.

lekez2005 avatar Oct 15 '24 03:10 lekez2005

@lekez2005 here is the sample https://drive.google.com/drive/folders/1K9Qk6P8ljT4pTefmIi6TT1Mdi1otls-w?usp=sharing take a look at it whenever you are free

yahia3200 avatar Oct 15 '24 13:10 yahia3200

@yahia3200 I was able to determine the root cause of the crash to be that the file was large enough to overflow int32. I have pushed a fix to the https://github.com/lekez2005/libpsf/tree/uint_32_bugfix branch. This "fix" changes int to unsigned int for some size and offset variables. It successfully parses the data but I don't actually know if the result is correct. Can you test to see if the data is correctly processed? If it is, I'll merge the changes to the main branch.

lekez2005 avatar Nov 02 '24 20:11 lekez2005