helm icon indicating copy to clipboard operation
helm copied to clipboard
verified publisher icon helm

Recreate immutable resources on upgrade

Open Vegoo89 opened this issue 2 years ago • 5 comments

Closes #7082

What this PR does / why we need it: This PR tries to solve the recreation resources problem in minimalistic way by adding new --recreate-immutable-resources argument to command line for helm upgrade only. It should be mentioned that I read the whole discussion about the issues and I understand why maintainers are not eager to merge it, but I thought I will give it a try. In my solution I would like to mark this feature as experimental (which I was not sure how to do) or just explicitly mention that if it would be used, bad things may happen (like example with deleting PVC). However - as a helm user - I would like to use it myself in non-critical workflows where for example I change labels for my deployment.

Special notes for your reviewer: I am pretty sure reviewers are familiar with this problem. I didn't want to introduce the breaking change and I thought additional function parameter in Update is not breaking, but I may be wrong. If you think MR is worth to work on, I am happy to spend some more time on it, however if you think merging this would be very difficult or this is not really the feature you are looking for, information would also be appreciated.

If applicable:

  • [ ] this PR contains documentation
  • [x] this PR contains unit tests
  • [ ] this PR has been tested for backwards compatibility

Signed-off-by: Jakub Domanski [email protected]

Vegoo89 avatar Oct 23 '23 10:10 Vegoo89

What happens if an upgrade fails but --atomic is set?

joejulian avatar Oct 24 '23 23:10 joejulian

What happens if an upgrade fails but --atomic is set?

Added handling for this. Totally missed it as I didn't really want to add this functionality neither to install, nor to rollback to keep the MR simple. With pushed changes --atomic should reverse the release (so delete existing resource and create old one).

Vegoo89 avatar Oct 25 '23 08:10 Vegoo89

This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar Aug 23 '25 00:08 github-actions[bot]

remove stale

dastrobu avatar Aug 27 '25 05:08 dastrobu

This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar Dec 01 '25 00:12 github-actions[bot]