helm icon indicating copy to clipboard operation
helm copied to clipboard

feat(helm): add chart name, version and app version to the status

Open carrodher opened this issue 4 years ago • 5 comments

Signed-off-by: Carlos Rodriguez Hernandez [email protected]

What this PR does / why we need it:

I would like to see in the installation output after helm install or helm status some info about the chart that is being installed such as the chart name, chart version, and app version:

$ bin/helm install my-kafka bitnami/kafka --version 14.2.3
RELEASE NAME: my-kafka
CHART: kafka-14.2.3
APP VERSION: 2.8.1
LAST DEPLOYED: Sat Nov 13 13:37:54 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
** Please be patient while the chart is being deployed **

Kafka can be accessed by consumers via port 9092 on the following DNS name from within your cluster:

    my-kafka.default.svc.cluster.local
...

$ bin/helm status my-kafka
RELEASE NAME: my-kafka
CHART: kafka-14.2.3
APP VERSION: 2.8.1
LAST DEPLOYED: Sat Nov 13 13:37:54 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
** Please be patient while the chart is being deployed **

Kafka can be accessed by consumers via port 9092 on the following DNS name from within your cluster:

    my-kafka.default.svc.cluster.local
...

Being the difference with the current output:

-$ helm status my-kafka
+$ bin/helm status my-kafka

-NAME: my-kafka
+RELEASE NAME: my-kafka
+CHART: kafka-14.2.3
+APP VERSION: 2.8.1
LAST DEPLOYED: Sat Nov 13 13:37:54 2021
NAMESPACE: default

Special notes for your reviewer:

  • Fixes #10256

If applicable:

  • [ ] this PR contains documentation
  • [X] this PR contains unit tests
  • [X] this PR has been tested for backwards compatibility

carrodher avatar Nov 13 '21 13:11 carrodher

👋 Sorry to ping you directly @bacongobbler but since you labeled the related issue, what do you think about the changes?

carrodher avatar Nov 19 '21 15:11 carrodher

Hi @mattfarina, do you have an opinion on this topic? How can it be reviewed? Thx

carrodher avatar Dec 15 '21 18:12 carrodher

👋 Can someone review this PR? Thanks!

carrodher avatar Mar 10 '22 22:03 carrodher

It's been a while since this failed CI. It'll need to pass, of course. Can you please fix the test failures?

joejulian avatar Nov 15 '22 00:11 joejulian

Also, this output change could break any end-user scripts that scrape the output. The maintainers may require this to be behind a feature flag to maintain backward compatibility.

Does this (or should it) have any impact on other --output choices?

joejulian avatar Nov 15 '22 01:11 joejulian