chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

feat: options to configure chart upgrade strategy

Open tthvo opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

Added options (i.e. --upgrade-strategy <option>) to configure upgrade strategy for chart values. This allows maintainers to choose whichever upgrade paths align with their charts.

Without specifying the flag, default to reuse-values for backwards compatibility.

Follow up for #531

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #525

Special notes for your reviewer:

Sorry if it duplicates any in-progress work. Please let me know what you think :D

tthvo avatar May 26 '24 05:05 tthvo

Hi @cpanato, would you have time to look at this? Sorry, I can't add/tell who to request reviews :D

tthvo avatar Jun 06 '24 06:06 tthvo

This is great, this would fix the issues I'm having where the chart upgrade path cannot be tested because of the adding of new default values which don't get included in the upgrade.

jochbru avatar Jul 12 '24 09:07 jochbru

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 05 '24 01:11 github-actions[bot]

Hi, would anyone mind having a look at this PR? I think it would be useful for testing with different upgrade paths.

tthvo avatar Nov 05 '24 02:11 tthvo

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 21 '24 01:12 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Dec 26 '24 01:12 github-actions[bot]

Hi, Can someone take a look at this PR? I think it will help a lot of people running into this issue. Thanks.

rm3l avatar Feb 14 '25 13:02 rm3l

I haven't looked into this for long. Let me rebase the PR and reopen it this week if it is still a good solution 😅

tthvo avatar Mar 18 '25 18:03 tthvo