feat(helm): Add support for OCI chart repositories
What this PR does / why we need it: Since Helm 3.8 the support of OCI registries is no longer experimental and is enabled by default, this means that more and more people will be using registries to store charts. In order to support this type of repository, a small change is needed because OCI registries can't be added like "regular repositories", and need to use a different command "helm registry login".
Therefore, and since it was already agreed that OCI repositories should start the URL with "oci://" this PR uses the prefix of the repository URL to select the right command to be able to add these type of repositories.
Special notes for your reviewer: I didn't added any automation test because didn't find any similar to what already was done, I tested this locally using a registry of mine.
Signed-off-by: João Fernandes [email protected]
can someone review this? we're adopting OCI and currently running this custom build as workaround
bumping this up for visibility :)
Can a maintainer look at this? It is a really small review that helps a lot of users.
+1 on this feature https://github.com/pipe-cd/pipecd/issues/4588
@jcsf sorry for the delay here, can you rebase and fix the lint issues?
@jcsf sorry for the delay here, can you rebase and fix the lint issues?
Sure, will work on this today and update the PR.
@cpanato Please retrigger the pipelines I believe the linter is fixed and the branch rebased.