chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

feat(helm): Add support for OCI chart repositories

Open jcsf opened this issue 3 years ago • 2 comments

What this PR does / why we need it: Since Helm 3.8 the support of OCI registries is no longer experimental and is enabled by default, this means that more and more people will be using registries to store charts. In order to support this type of repository, a small change is needed because OCI registries can't be added like "regular repositories", and need to use a different command "helm registry login".

Therefore, and since it was already agreed that OCI repositories should start the URL with "oci://" this PR uses the prefix of the repository URL to select the right command to be able to add these type of repositories.

Special notes for your reviewer: I didn't added any automation test because didn't find any similar to what already was done, I tested this locally using a registry of mine.

Signed-off-by: João Fernandes [email protected]

jcsf avatar Jun 08 '22 15:06 jcsf

can someone review this? we're adopting OCI and currently running this custom build as workaround

tuananh-finx avatar Jun 20 '22 09:06 tuananh-finx

bumping this up for visibility :)

tuananh avatar Aug 12 '22 06:08 tuananh

Can a maintainer look at this? It is a really small review that helps a lot of users.

jcsf avatar Jan 26 '23 15:01 jcsf

+1 on this feature https://github.com/pipe-cd/pipecd/issues/4588

hungran avatar Sep 04 '23 03:09 hungran

@jcsf sorry for the delay here, can you rebase and fix the lint issues?

cpanato avatar Oct 27 '23 08:10 cpanato

@jcsf sorry for the delay here, can you rebase and fix the lint issues?

Sure, will work on this today and update the PR.

jcsf avatar Oct 27 '23 10:10 jcsf

@cpanato Please retrigger the pipelines I believe the linter is fixed and the branch rebased.

jcsf avatar Oct 27 '23 10:10 jcsf