chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

Draft: feat(repo): change matching regex for maintainers validation

Open JBOClara opened this issue 3 years ago • 1 comments

What this PR does / why we need it:

Change repoDomainPattern used to retrieve maintainers.

Which issue this PR fixes

Fix #399

JBOClara avatar Feb 28 '22 15:02 JBOClara

I'm a bit confused since what I wanted to change is currently not expected by current tests:

Specifically this one {"Gitlab HTTPS with username/password", "https://gitlab-ci-token:[email protected]/foo/bar", "gitlab.com", nil},

		{"GitHub SSH", "[email protected]:foo/bar", "github.com", nil},
		{"GitHub HTTPS", "https://github.com/foo/bar", "github.com", nil},
		{"GitHub HTTPS with username/password", "https://foo:[email protected]/foo/bar", "github.com", nil},
		{"Gitlab SSH", "[email protected]:foo/bar", "gitlab.com", nil},
		{"Gitlab HTTPS", "https://gitlab.com/foo/bar", "gitlab.com", nil},
		{"Gitlab HTTPS with username/password", "https://gitlab-ci-token:[email protected]/foo/bar", "gitlab.com", nil},
		{"Bitbucket SSH", "[email protected]:foo/bar", "bitbucket.com", nil},
		{"Bitbucket HTTPS", "https://bitbucket.com/foo/bar", "bitbucket.com", nil},
		{"Bitbucket HTTPS with username/password", "https://user:[email protected]/foo/bar", "bitbucket.com", nil},

JBOClara avatar Feb 28 '22 15:02 JBOClara

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 10 '23 01:11 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Nov 15 '23 01:11 github-actions[bot]