chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

feat(lint): add yamale and yamllint extra-args flags

Open acobaugh opened this issue 3 years ago • 10 comments

What this PR does / why we need it:

This adds --yamllint-extra-args and --yamale-extra-args flags to ct lint. Yamllint in particular has options

Which issue this PR fixes:

This allows users of ct to fix or workaround https://github.com/helm/chart-testing-action/issues/70 by passing --yamllint-extra-args -f,standard.

Special notes for your reviewer:

The issue with the default github formatting with yamllint is github seems to swallow the important information that is output when yamllint detects it is running under a github action, as can be seen in https://github.com/helm/chart-testing-action/issues/70.

If it would be preferable to just hardcode -f standard into ct, I can issue a PR to do that, too, but being able to fully customize how yamale and yamllint are run might be useful for other situations, too.

acobaugh avatar Jan 25 '22 22:01 acobaugh

@acobaugh thanks for the PR, can you please rebase this with the latest code in main?

cpanato avatar Mar 14 '22 09:03 cpanato

@cpanato Done!

acobaugh avatar Mar 14 '22 16:03 acobaugh

hey, just realize that you need to generate the docs

go build -o ct-bin ./ct/main.go

$ ./ct-bin doc-gen
Generating docs...
Done.

cpanato avatar Mar 23 '22 13:03 cpanato

@cpanato done!

acobaugh avatar Mar 23 '22 13:03 acobaugh

there are some failures, can you take a look when you have a chance? thanks!

cpanato avatar Apr 01 '22 11:04 cpanato

Alright, tests passed locally for me this time. Let's give this another go.

acobaugh avatar Apr 05 '22 04:04 acobaugh

there are some conflicts are you able to rebase? thanks

cpanato avatar Jul 28 '22 09:07 cpanato

@cpanato done!

acobaugh avatar Jul 28 '22 17:07 acobaugh

i will run that locally

cpanato avatar Jul 29 '22 12:07 cpanato

@acobaugh there are some tests failures can you check that when you have some time?

cpanato avatar Jul 29 '22 12:07 cpanato

need some rebase

cpanato avatar Sep 27 '22 12:09 cpanato

rebased.

acobaugh avatar Oct 12 '22 15:10 acobaugh

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 11 '23 01:11 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Nov 16 '23 01:11 github-actions[bot]