chart-releaser icon indicating copy to clipboard operation
chart-releaser copied to clipboard

cr crashes as package version gets accidentially encoded

Open michas2 opened this issue 3 years ago • 1 comments

Packet versions follow semantic versioning, which allows adding build metadata to have versions like this: 3.11627+2e5eff15bf01

cr uses the name and the version to create files like this: cloudbees-core-3.11627+2e5eff15bf01.tgz

Then, in releaser.go it calls downloadURL.String() which will give the encoded representation like this: cloudbees-core-3.11627%2B2e5eff15bf01.tgz

Therefore the file will not be found and cr crashes.

Please stick with the unencoded filename there to avoid this.

michas2 avatar Apr 19 '23 12:04 michas2

We're running into the same problem.

Chart.yaml

version: "2.2.5+2"

https://github.com/relution-io/relution-kubernetes/commit/98b89d46ff96e4daa40f8732854b7f4bda0776c0

mway-niels avatar Mar 13 '24 02:03 mway-niels