Sagar Khurana

Results 119 comments of Sagar Khurana

@hoisie just a gentle reminder to review 😄

I was in a doubt that its related visibility issue(public, protected and private related), Thanks for sharing I will check it out

@utzcoz I've learned about what ServiceLoader is and now that I know ServiceLoader, I checked that StackOverflow post that you shared - https://stackoverflow.com/questions/46032368/kotlin-annotation-processor-cant-make-it-work, basically Kotlin is ignoring the Autoservice tag....

I've rebased the class against the latest merge and if its in Java the `utils` module all tests are passing

Since we have to keep it in Java, so we can keep it closed as well

> @hellosagar Look like new commit to applying google java format generates a reasonable change lines, instead of previous multi thousands lines. Yes :)

um.. lme check that locally on my system

@utzcoz you are right, I little surprised how it passed in the CI but mainly [AttributeResolution10.java](https://github.com/robolectric/robolectric/blob/ac9c16b542e9b0db8682f0fe22c92960a95912e1/resources/src/main/java/org/robolectric/res/android/AttributeResolution10.java) contains a lot of weird indentation, Ive reformat it locally, pushing it again

> Why formatted change lines increase a lot again? because I open that file and pressed the `cmd + ctrl + L ` which performed the google style format as...