eks-rolling-update icon indicating copy to clipboard operation
eks-rolling-update copied to clipboard

Suggestion for fixing the exclude nodes filter

Open dgem opened this issue 3 years ago • 0 comments

Hi,

As per comment from @js-timbirkett, the filtering of nodes via EXCLUDE_NODE_LABEL_KEYS doesn't seem to work.

As a suggestion, I've modified get_k8s_nodes() to return nodes, excluded_nodes , then modified the callers of it, etc.

Also fixes: https://github.com/hellofresh/eks-rolling-update/issues/94

Let me know what you think,

Kind regards Dan

dgem avatar Jun 27 '22 09:06 dgem