bootstrap-flask icon indicating copy to clipboard operation
bootstrap-flask copied to clipboard

Add an optional parameter for render_table()

Open grant-sea opened this issue 2 years ago • 7 comments

Add an optional parameter for render_table() to allow setting the location of the actions column. The two options are "front" (the 1st column of the table) and "end" (default value, the last column of the table).

grant-sea avatar Apr 01 '23 15:04 grant-sea

Looks nice. @greyli how about actions_front=True using a bool instead of a string?

PanderMusubi avatar Apr 06 '23 07:04 PanderMusubi

Looks nice. @greyli how about actions_front=True using a bool instead of a string?

Yes. that's also my first thought. I was struggling about that. But you are right, a bool will be better. And I found a more compact way to implement this function after I read Greyli's Flask book :). How can I recall this PR and edit it again? Thanks for the hlep.

grant-sea avatar Apr 09 '23 12:04 grant-sea

put your new edits in a new commit with a new commit message, then run git rebase -i HEAD~2

change the first word before the commit message of the latest commit into squash

save and exit that file, then remove the new commit messages and leave only the old commit message at the top of the next file.

save and exit that and do git push -f which will push it here and override the old commit.

PanderMusubi avatar Apr 09 '23 13:04 PanderMusubi

put your new edits in a new commit with a new commit message, then run git rebase -i HEAD~2

change the first word before the commit message of the latest commit into squash

save and exit that file, then remove the new commit messages and leave only the old commit message at the top of the next file.

save and exit that and do git push -f which will push it here and override the old commit.

Thanks for the instructions. But it seems quite complicated to me. I only use the github website operations. I suppose I have done the new commit. But I don't know how to move the PR from Draft back to acitve. Could you please help? Thanks!

grant-sea avatar Apr 09 '23 14:04 grant-sea

Just make another commmit and push that. @greyli can merge them later.

PanderMusubi avatar Apr 09 '23 17:04 PanderMusubi

Just make another commmit and push that. @greyli can merge them later.

I have moved the PR back to open status (2nd commit done). Thanks!

grant-sea avatar Apr 10 '23 12:04 grant-sea