ISO icon indicating copy to clipboard operation
ISO copied to clipboard

QTerminal: Use Qt-wide keyboard shortcut for "Quit"

Open probonopd opened this issue 4 years ago • 4 comments

Expected Behavior

The ususal Qt-wide keyboard shortcut for quitting application works

Current Behavior

Quit has no shortcut at all

image

Upstream issue opened: https://github.com/lxqt/qterminal/issues/862

probonopd avatar Oct 16 '21 10:10 probonopd

Upstream seems unwilling to change this.

Options:

  • Fork QTerminal and lximage-qt to do the changes that were rejected upstream (however, I'd like to avoid forking everything for "small" things like these)
  • Monkey-patch the shortcuts, possibly using LD_PRELOAD as we are doing in https://github.com/helloSystem/QKeySequenceOverride (is this even possible?)
  • Maybe @antony-jr has an idea how to do this using a Qt plugin?
  • Maybe @jsm222 has ideas?
  • Given this bug report maybe @grahamperrin has ideas on this? (In the meantime, I will prepopulate the config file but that really feels not ideal)

probonopd avatar Oct 16 '21 11:10 probonopd

We could in fact do this with qt plugins but does QTerminal load style plugins and something like that? or else we have to do some very bad unmaintainable code. Without forking we could maintain a set of patch over the project which can be applied when building.

antony-jr avatar Oct 16 '21 14:10 antony-jr

At least on helloSystem (which is what we are caring about here) we are loading our own style plugin https://github.com/helloSystem/QtPlugin/tree/master/styleplugin for all applications but since we are using Qt Style Sheets, it seems that not much of our style plugin is actually used to do the widget drawing.

This is not super urgent given the workaround that I am using now (shipping a prepopulated config file) but I am interested in learning which options there are and what can or cannot be done using Qt Plugins.

probonopd avatar Oct 16 '21 15:10 probonopd

qterminal has a config file with shortcuts just like featherpad..

jsm222 avatar Nov 12 '21 13:11 jsm222