webapp icon indicating copy to clipboard operation
webapp copied to clipboard

add a linter

Open seport opened this issue 6 years ago • 3 comments

Can we plz add eslint to the project at some point thx

also this should include running the linter and adding the linter to whatever CI we have set up

seport avatar Jul 02 '19 03:07 seport

@seport The linter config file is this one no?

ahrGNUts avatar Jul 09 '19 18:07 ahrGNUts

then this story is to run the linter on all the project files 😂

seport avatar Sep 10 '19 23:09 seport

I like the eslint recommended set of rules, which roughly are the de facto standards. I'd suggest:

module.exports = {
  env: {
    node: true,
    browser: true,
  },
  extends: 'eslint:recommended',
  parserOptions: {
    sourceType: 'script',
    ecmaVersion: 10,
  },
  rules: {
    'no-console': 0, // I'd leave this in til we get a proper logging library
  },
}

I ran eslint . with that config and we have: 14 errors, 29 warnings. Most warnings are about console logs and the errors don't look too complicated.

beekley avatar Feb 11 '20 04:02 beekley