fsharp-hedgehog icon indicating copy to clipboard operation
fsharp-hedgehog copied to clipboard

Add more detailed state for property.

Open adam-becker opened this issue 4 years ago • 4 comments

This PR aggregates all the "check time" state of a property into a single structure. This will hopefully make adding features like #341 easier, and I think it's much easier to see at a glance what's happening internally by looking at the new PropertyState module.

/cc @TysonMN @dharmaturtle

adam-becker avatar Sep 21 '21 21:09 adam-becker

Can we merge #336 first? I don't want to fix merge conflicts.

TysonMN avatar Sep 21 '21 23:09 TysonMN

I like this a lot.

dharmaturtle avatar Sep 22 '21 02:09 dharmaturtle

Can we merge #336 first? I don't want to fix merge conflicts.

Absolutely. Are we still waiting on a Fable issue there?

I like this a lot.

:+1:

ghost avatar Sep 22 '21 14:09 ghost

Can we merge #336 first? I don't want to fix merge conflicts.

Absolutely. Are we still waiting on a Fable issue there?

We are primarily waiting on PR #364 to be reviewed and completed. After that, we could merge PR #336 with understanding that the API needs some work, but maybe that is ok since improving the API around Property is what issue #365, PR #346, and this PR are intended to do.

And the issue with Fable is minor. The simple fix is to comment out one of the assertions. I think it would be better to have that assertion, but it isn't the only assertion, and we can wait to comment back in this second assertion once issue with Fable is resolved.

TysonMN avatar Sep 23 '21 00:09 TysonMN