XenonRecomp icon indicating copy to clipboard operation
XenonRecomp copied to clipboard

added missing instructions for destroy all humans path of the furon

Open masterspike52 opened this issue 1 year ago • 6 comments

masterspike52 avatar Mar 30 '25 01:03 masterspike52

I'm a bit confused that the implemented instructions seem to be using intrinsics or union fields that don't exist anywhere?

blueskythlikesclouds avatar Apr 04 '25 14:04 blueskythlikesclouds

Full disclosure, used AI to make these and they worked for making the files (however I'm not sure if they're accurate?)

masterspike52 avatar Apr 04 '25 14:04 masterspike52

I don't think any of these are actually going to compile, the accessed fields or intrinsics do not exist.

blueskythlikesclouds avatar Apr 04 '25 14:04 blueskythlikesclouds

I just assume they work due to compiling xenonrecomp and no longer getting the errors for missing those instructions. The files that xenonrecomp spits out do compile (I've managed the basic hello world and at one point even had an sdl box for graphics but it just didn't show any graphics) but I can't really argue if they actually work

masterspike52 avatar Apr 04 '25 14:04 masterspike52

I just assume they work due to compiling xenonrecomp and no longer getting the errors for missing those instructions. The files that xenonrecomp spits out do compile (I've managed the basic hello world and at one point even had an sdl box for graphics but it just didn't show any graphics) but I can't really argue if they actually work

You can verify that your functions are correct by comparing the modified registers before and after each function call with your compiled code vs. Xenia. I recognize some of your implemented functions from the NG2 instructions PR and they differ.

JillianTo avatar Apr 04 '25 15:04 JillianTo

Full disclosure, used AI to make these and they worked for making the files (however I'm not sure if they're accurate?)

AI is almost guaranteed to get this completely wrong.

I just assume they work due to compiling xenonrecomp and no longer getting the errors for missing those instructions. The files that xenonrecomp spits out do compile (I've managed the basic hello world and at one point even had an sdl box for graphics but it just didn't show any graphics) but I can't really argue if they actually work

The programs you fed XenonRecomp probably don't use these instructions so how can you know if it's working. Of course it didn't give you errors for missing instructions, you added the missing instructions. XenonRecomp just emits text, it doesn't tell you if the code it emits is actually valid.

IsaacMarovitz avatar Apr 12 '25 18:04 IsaacMarovitz