propose alternative chunk shape algorithm
Motivation
Fix #995
How to test the behavior?
Show how to reproduce the new behavior (can be a bug fix or a new feature)
Checklist
- [ ] Did you update CHANGELOG.md with your changes?
- [ ] Have you checked our Contributing document?
- [ ] Have you ensured the PR clearly describes the problem and the solution?
- [ ] Is your contribution compliant with our coding style? This can be checked running
rufffrom the source directory. - [ ] Have you checked to ensure that there aren't other open Pull Requests for the same change?
- [ ] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
In general, I think this is reasonable. @CodyCBakerPhD can you also take a look.
Another approach could be to work with the prime factorization of the residual product of the size. That would get us closer to the desired chunk size but we could end up with very uneven shapes
Another approach could be to work with the prime factorization of the residual product of the size. That would get us closer to the desired chunk size but we could end up with very uneven shapes
Uneven shape is not necessarily bad, but I think you probably want the ratio to be informed by the overall size of the dataset. I.e., for (time, electrodes) where time is much longer than electrodes, then you'd also want the chunks to be larger in the time dimension.