hazelcast-python-client icon indicating copy to clipboard operation
hazelcast-python-client copied to clipboard

[TRACKING ISSUE] custom load balancer declarative configuration

Open ghost opened this issue 5 years ago • 1 comments

The tracking issue for the Java side PR.

custom load balancer declarative configuration

See https://github.com/hazelcast/hazelcast/pull/17415 for details.


Fixes https://github.com/hazelcast/hazelcast/issues/17228

Changes:

  • "custom" balancer type was introduced (as suggested)
  • XML, YAML config loading supports new balancer type
  • Spring bean class name or reference is also supported for "custom" type

I'm aware that there have to be seperate PRs for other branches. Are you guys able to cherry pick this change onto 4.0.z and 4.z branches or do I have to open separate PRs? (this will take some time)

Can you help review this first?

ghost avatar Jan 26 '21 15:01 ghost

We don't have the notion of declarative configuration for the Python client but I am leaving this open.

We maybe provide a way to set the load balancer via some string to a class like the below as an enhancement.

The current way.

client = hazelcast.HazelcastClient(
    load_balancer=MyLoadBalancer()    
)

The proposed enhancement along with the current way

client = hazelcast.HazelcastCient(
    load_balancer="my.module.MyLoadBalancer"
)

It is just a suggestion though. We may decide to close this

mdumandag avatar Jan 28 '21 13:01 mdumandag