hazelcast-cpp-client icon indicating copy to clipboard operation
hazelcast-cpp-client copied to clipboard

Fix build with Boost 1.86.0.

Open BillyONeal opened this issue 1 year ago • 3 comments

Fixes https://github.com/hazelcast/hazelcast-cpp-client/issues/1245

boost::uuid::uuid is no longer trivial, and data is no longer an array, but a type providing overloaded operators that attempt to "look like" an array.

These changes should be safe on previous boost versions.

BillyONeal avatar Oct 16 '24 20:10 BillyONeal

CLA assistant check
All committers have signed the CLA.

devOpsHazelcast avatar Oct 16 '24 20:10 devOpsHazelcast

I've asked our Legal folks for permission to sign the CLA.

BillyONeal avatar Oct 16 '24 20:10 BillyONeal

Legal gave me permission, CLA now signed :)

BillyONeal avatar Oct 17 '24 18:10 BillyONeal

PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

devOpsHazelcast avatar Jan 20 '25 21:01 devOpsHazelcast

@JackPGreen Could you reconsider looking at this? If hazelcast can't be built with current boost we are going to be forced to remove it from our curated registry.

BillyONeal avatar Feb 10 '25 19:02 BillyONeal

Unfortunately, it looks like 1.87 broke even more stuff :(

BillyONeal avatar Feb 25 '25 19:02 BillyONeal

Unfortunately, it looks like 1.87 broke even more stuff :(

I'm not sure if you've spotted something locally, or if it's the failing CI builds - if the latter, this PR has flagged some separate issues that we're addressing in parallel :)

Thanks for the contribution!

JackPGreen avatar Feb 25 '25 21:02 JackPGreen

I'm not sure if you've spotted something locally, or if it's the failing CI builds - if the latter, this PR has flagged some separate issues that we're addressing in parallel :)

I mean https://github.com/microsoft/vcpkg/pull/42678 which tries to update vcpkg to 1.87. We are likely to remove hazelcast-cpp-client from our registry in order to take the boost update (and will of course add it back as soon as we have a hazelcast-cpp-client that successfully builds)

BillyONeal avatar Feb 25 '25 22:02 BillyONeal

I'm not sure if you've spotted something locally, or if it's the failing CI builds - if the latter, this PR has flagged some separate issues that we're addressing in parallel :)

I mean microsoft/vcpkg#42678 which tries to update vcpkg to 1.87. We are likely to remove hazelcast-cpp-client from our registry in order to take the boost update (and will of course add it back as soon as we have a hazelcast-cpp-client that successfully builds)

It is this reported issue. We have to look for upgrading boost to a more recent version as minimum required version and fixing the related problems.

ihsandemir avatar Feb 26 '25 08:02 ihsandemir

I mean microsoft/vcpkg#42678 which tries to update vcpkg to 1.87.

Looks like this landed, which deindexed hazelcast-cpp-client. Just wanted to stress that this isn't intended to be punitive; it's just that the amount of patch to respond to the asio changes was more than we were willing to do as mere package management maintainers. We would love to add it back as soon as we have a copy that works with 1.87.

BillyONeal avatar Mar 03 '25 19:03 BillyONeal

@ihsandemir now that Boost 1.88 is supported in https://github.com/hazelcast/hazelcast-cpp-client/pull/1334, is this PR still necessary?

JackPGreen avatar Oct 21 '25 13:10 JackPGreen

fixed by https://github.com/hazelcast/hazelcast-cpp-client/pull/1322

closing this PR.

ihsandemir avatar Oct 21 '25 14:10 ihsandemir