John Hatton

Results 53 comments of John Hatton

The plugin isn't being called because the regular expression in your code above was only matching on URLs, rather than the complete markdown link. This works for matching: `const linkNotionRegExp...

Well actually, two reasons. The other is that docu-notion isn't applying changes inside of code blocks, which normally would be what we want, right? The normal point of a code...

I'm working on seeing if this would be an appropriate approach: ```typescript const mermaidLinks: IPlugin = { name: "mermaidLinks", regexMarkdownModifications: [ { regex: /```mermaid\n.*"(https:\/\/www\.notion\.so\S+)"/, getReplacement: async (context: IDocuNotionContext, s: string)...

OK, @dionjwa please see the branch `linkConversionFromPlugin` and the [sample mermaid plugin](https://github.com/sillsdev/docu-notion/blob/linkConversionFromPlugin/src/plugins/mermaidLinkPlugin.spec.ts) there. If it is enough, then I can get that branch merged so that you can use this...

We're going to have to return to this as a plugin.

Docu-notion does convert notion URLs to ones that work with docusaurus, so there's reason to hope?

> The block object received for a numbered_list_item, as far as I can tell, contains no indication of how it is numbered in Notion Right, see #35

@danielbair part of the problem is this major change was introduced without so much as a *patch* number increase. Because of the problems that change is making, we would like...

I assume this is the issue y'all are discussing, and for my future self. To fix `Module not found: Error: Can't resolve 'spark-md5' in 'C:\dev\lameta\node_modules\@segment\analytics-core\dist\esm\events'` with node 16, I had...