hatchet icon indicating copy to clipboard operation
hatchet copied to clipboard

fix: Fix checking value in Golang ValidateJSONB

Open icbd opened this issue 4 months ago • 2 comments

Description

https://github.com/hatchet-dev/hatchet/blob/2a08cbf77b98da6c21c1417ec25dfc42f075208f/sdks/python/hatchet_sdk/worker/runner/runner.py#L501-L506

This comment has explained the significance of this method, but the implementation of this method has problems. This PR fixes the value of this check.

Fixes # (issue)

When the object returned normally contains "\u0000", the task will be reset to failure.

Source Code: https://github.com/hatchet-dev/hatchet/blob/5bf9f97720aba5a8095b69fc69e510ce424db4f1/internal/services/dispatcher/server_v1.go#L557-L562

When the object returned error contains "\u0000", the error content is displayed normally (No check for ValidateJSONB).

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Documentation change (pure documentation change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking changes to code which doesn't change any behaviour)
  • [ ] CI (any automation pipeline changes)
  • [ ] Chore (changes which are not directly related to any business logic)
  • [ ] Test changes (add, refactor, improve or change a test)
  • [ ] This change requires a documentation update

What's Changed

  • [ ] Add a list of tasks or features here...

icbd avatar Oct 04 '25 15:10 icbd

@icbd is attempting to deploy a commit to the Hatchet Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 04 '25 15:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hatchet-docs Ready Ready Preview Comment Oct 7, 2025 3:03am
hatchet-v0-docs Ready Ready Preview Comment Oct 7, 2025 3:03am

vercel[bot] avatar Oct 07 '25 02:10 vercel[bot]