packages icon indicating copy to clipboard operation
packages copied to clipboard

Fails to check doctests

Open ldicarlo opened this issue 2 years ago • 5 comments

Currently this package prevent people from running ghcup on nixos.

I think the error message expected in DocTests changed.

I am trying to prepare a PR.

ldicarlo avatar Oct 23 '23 14:10 ldicarlo

It's likely due to https://github.com/haskus/packages/commit/59bf718e5dd1d8ca63046ded07e90e53f659d562

I guess the output now depends on the version of haskus-utils-types used.

hsyl20 avatar Oct 23 '23 15:10 hsyl20

Do you mean that we cannot fix it? Locally, tests won't pass when running stack test. Is it expected to be different for others distributions ?

ldicarlo avatar Oct 23 '23 15:10 ldicarlo

If we can fix it to use the newer message, let's do it. It has been stable for several years already now.

If it's not possible I don't mind if we disable this test and convert it into unchecked documentation instead.

hsyl20 avatar Oct 23 '23 17:10 hsyl20

I tried to do it but I need some guidance. I have a lot of doctests failing siren running stsck test and using import does not always work. Can you tell me how we should do?

ldicarlo avatar Oct 24 '23 05:10 ldicarlo

I've tested with the old stack.yaml and it passes.

stack --stack-yaml stack-8.10.yaml test haskus-utils-variant

I've tried with different compilers:

  • lts-18.28 (ghc 8.10.7): pass
  • lts-19.9 (ghc 9.0.x): fail to find V
  • lts-19.33 (ghc-9.0.2): fail to find V
  • lts-20.11 (ghc-9.2.5): fail with the error you get

I've pushed a fix. Strangely enough, it still passes with 8.10 while I expected it to break.

hsyl20 avatar Oct 24 '23 07:10 hsyl20

I've fixed the testsuite and the doctests now pass (cf CI here)

hsyl20 avatar Jul 30 '24 09:07 hsyl20