aeson icon indicating copy to clipboard operation
aeson copied to clipboard

Add instances for URI from network-uri

Open phadej opened this issue 4 years ago • 3 comments

:+1: / :-1:, @bergmark ?

phadej avatar Feb 28 '21 10:02 phadej

Looks like this adds network-uri+parsec+th-compat to our dependencies?

My gut reaction is always no to more dependecies, haha, but I'm also in favor of batteries included so I don't mind either way. Really wish there was a better solution for this on the package level!

bergmark avatar Mar 05 '21 07:03 bergmark

Hmm. parsec is unfortunate, but it's bundled with GHC. th-compat is a compat module, which I wouldn't be afraid to depend upon (I'd rather promote that people use it over reimplementing the compat stuff themselves). So this would add "only" network-uri dependency.

phadej avatar Mar 06 '21 15:03 phadej

I created a PR to add a Read instance for the URI data type. This would make it easier to create a URI constructor for the Value data type.

erinclemmer avatar Jul 03 '22 16:07 erinclemmer