actions icon indicating copy to clipboard operation
actions copied to clipboard

Add GHC 9.4.2 and Stack 2.9.1

Open andreasabel opened this issue 3 years ago • 1 comments

Add GHC 9.4.2 and Stack 2.9.1.

andreasabel avatar Sep 30 '22 05:09 andreasabel

@hazelweakly CI passes; I'd be grateful if this PR gets released quickly (in case it also works fine in reality). The reason is that we have some mysterious CI freezes with Stack 2.7.5 on the latest Windows virtual environment, and I would like to test whether Stack 2.9.1 resolves this.

andreasabel avatar Sep 30 '22 06:09 andreasabel

Eager for this to go in, I need the stack ls tools command in 2.9.1 to get the msys version used in my Windows CI.

yutotakano avatar Oct 18 '22 13:10 yutotakano

I realized that haskell/actions/setup does allow e.g. stack-2.9.1 if the version is specified in full, like 2.9.1. However, 2.9 cannot be resolved (without this PR) and also latest is outdated. (Same for ghc.)

Ping @hazelweakly .

andreasabel avatar Oct 18 '22 21:10 andreasabel

@hazelweakly I'd say this PR is safe to merge. What do you think?

andreasabel avatar Oct 29 '22 13:10 andreasabel

Ping @hazelweakly.

andreasabel avatar Nov 19 '22 16:11 andreasabel

I'd like to apologize for the late delay; it's been hard for me to have the energy to do OSS lately, but I've been able to finally pick it back up.

I also went through the repository permissions and realized I had somehow forgotten for nearly 2 years to add any of the haskell org groups... sigh. Not sure how this never came up, but I added relevant ones and also gave you commit bit because this isn't the first time I've kept you waiting for an unreasonable length of time on simple patches 😅

hazelweakly avatar Nov 21 '22 07:11 hazelweakly

I'd like to apologize for the late delay; it's been hard for me to have the energy to do OSS lately, but I've been able to finally pick it back up.

Apology accepted, happens to all of us, great that you are back!

I also went through the repository permissions and realized I had somehow forgotten for nearly 2 years to add any of the haskell org groups... sigh. Not sure how this never came up, but I added relevant ones and also gave you commit bit because this isn't the first time I've kept you waiting for an unreasonable length of time on simple patches 😅

Thanks for enabling me, which demands responsibility to me. So far, I could rely on you to assess the correctness of my patches. Ideally, CI would verify that added GHC default versions will work. E.g. if I added GHC 9.4.3 so that latest and 9.4 resolved to 9.4.3, I would like to test this setup (on the relevant github virtual environments), because in my experience, it sometimes does not work on Windows in the first iteration. But I guess this discussion should happen here:

  • https://github.com/haskell/actions/issues/116

andreasabel avatar Nov 21 '22 07:11 andreasabel