github icon indicating copy to clipboard operation
github copied to clipboard

Undocumented features from GitHub Enterprise

Open robbiemcmichael opened this issue 6 years ago • 2 comments

GitHub Enterprise supports additional features which don't seem to be documented in the public API. As a concrete example, there is an ldap_dn field for teams which allows their membership to be linked to an LDAP group, but unfortunately the field isn't listed in the docs for teams.

A couple of questions to clarify the intent of this library:

  • Are you willing to support features which are only available in GitHub Enterprise or does this just complicate the library?
  • Are you willing to add support for undocumented features provided the implementation is not incompatible with github.com?

robbiemcmichael avatar Dec 03 '19 12:12 robbiemcmichael

If the GitHub Enterprise features are documented somewhere, then I'm ok with supporting them.

EDIT: I'd expect that enterprise features are the ones which are documented well.

phadej avatar Dec 03 '19 12:12 phadej

Looks like they have separate documentation for the enterprise features, e.g. the ldap_dn field is documented here. I'll raise a PR for adding support for this field so we can have a concrete example of what it looks like and have the debate there for whether it's confusing for non-enterprise users.

robbiemcmichael avatar Dec 09 '19 03:12 robbiemcmichael