beam icon indicating copy to clipboard operation
beam copied to clipboard
verified publisher icon haskell-beam

Export generic classes

Open edsko opened this issue 4 years ago • 5 comments

beam relies very heavily on GHC generics, but the standard GHC generic instances are not appropriate for all use cases (motivating example in this case being large-records). Fortunately, the way GHC generics is set up allows us to use non-standard representations, provided that we can then define additional instances for whatever generic classes are necessary. The beam-large-records library provides integration for large-records with beam-core, by providing these additional instances, but this does mean that the generic classes must be exported from beam-core so that additional instances can be provided. This commit adds these exports.

edsko avatar Aug 19 '21 10:08 edsko

Any chance of this being considered for merging and releasing?

edsko avatar Mar 15 '22 13:03 edsko

I'm just a contributor as you are. I can't merge any pull request here. This should be safe to merge.

amano-kenji avatar Jan 01 '23 05:01 amano-kenji

@tathougies any chance of this being merged? I've just rebased this on the most recent master, and verified that

  • all beam tests pass for all components with ghc 8.8.4, 8.10.7, 9.0.2, and 9.2.5
  • all beam tests pass for all components with ghc 9.4.4, except beam-migrate (unrelated to this PR: #649)
  • all beam-large-records tests (the package that depends on this PR) pass for ghc 8.8.4, 8.107, 9.0.2, 9.2.5 and 9.4.4

edsko avatar Feb 28 '23 15:02 edsko

Rebased this once more. Verified that all beam's own tests pass with 8.8, 8.10, 9.0, 9.2, 9.4 and 9.6, as well as the beam-large-records tests.

Anyone?

edsko avatar May 29 '24 07:05 edsko

@ tathougies any chance of this being merged? I've just rebased this on the most recent master, and verified that

I think @kmicklas is the one handling maintenance lately actually

alexfmpe avatar May 29 '24 08:05 alexfmpe