beam icon indicating copy to clipboard operation
beam copied to clipboard

Generalise concat_ to work for IsSqlExpressionSyntaxStringTypes

Open ollef opened this issue 7 years ago • 1 comments

Could concat_ be generalised to have a type like

concat_
  :: (IsSqlExpressionSyntaxStringType syntax text, IsSql99ConcatExpressionSyntax syntax)
  => [QGenExpr context syntax s text] -> QGenExpr context syntax s text

or is there a good reason for its current type,

concat_
  :: IsSql99ConcatExpressionSyntax syntax
  => [QGenExpr context syntax s Text] -> QGenExpr context syntax s Text

?

Thanks for making this great library!

ollef avatar Oct 19 '18 12:10 ollef

I think there are instances of IsSqlExpressionSyntaxStringType for Maybe Text, but I'm not sure. I'll investigate.

On Fri, Oct 19, 2018 at 5:33 AM Olle Fredriksson [email protected] wrote:

Could concat_ be generalised to have a type like

concat_ :: (IsSqlExpressionSyntaxStringType syntax text, IsSql99ConcatExpressionSyntax syntax) => [QGenExpr context syntax s text] -> QGenExpr context syntax s text

or is there a good reason for its current type,

concat_ :: IsSql99ConcatExpressionSyntax syntax => [QGenExpr context syntax s Text] -> QGenExpr context syntax s Text

?

Thanks for making this great library!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tathougies/beam/issues/321, or mute the thread https://github.com/notifications/unsubscribe-auth/AATn8nppLnRbwQy2qoj3WguqLC7QRd1Dks5umcamgaJpZM4XwRQM .

tathougies avatar Oct 19 '18 17:10 tathougies