web-ui icon indicating copy to clipboard operation
web-ui copied to clipboard

Fix issue #1323 - redirect 404/403 in edit pages (agents, tasks, hash…

Open LuffyNoNika opened this issue 2 months ago • 1 comments

Proper handling for invalid detail routes across multiple modules. Previously, navigating manually to an edit page of a non-existent resource (e.g. /agents/show-agents/999/edit) would load the edit UI behind a “Not Found” message, and the global error modal would still appear.

LuffyNoNika avatar Nov 25 '25 10:11 LuffyNoNika

Seems you stuck on a very old master branch, please merge master locally into your branch to resolve the conflicts.

gluafamichl avatar Nov 25 '25 10:11 gluafamichl

Seems you stuck on a very old master branch, please merge master locally into your branch to resolve the conflicts.

That's true. I forgot to merge master locally, now It's done. I will fix the failing unit tests and upload again. Thanks.

LuffyNoNika avatar Nov 26 '25 11:11 LuffyNoNika

# npm audit report

@angular/common  20.0.0-next.0 - 20.3.13
Severity: high
Angular is Vulnerable to XSRF Token Leakage via Protocol-Relative URLs in Angular HTTP Client - https://github.com/advisories/GHSA-58c5-g7wp-6w37
fix available via `npm audit fix`
node_modules/@angular/common
  @angular/forms  4.4.0-RC.0 - 4.4.0 || 20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/forms
  @angular/platform-browser  20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  node_modules/@angular/platform-browser
  @angular/platform-browser-dynamic  20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/platform-browser-dynamic
  @angular/router  10.0.0-next.0 - 10.0.0-rc.1 || 20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/router

body-parser  2.2.0
Severity: moderate
body-parser is vulnerable to denial of service when url encoding is used - https://github.com/advisories/GHSA-wqch-xfxh-vrr4
fix available via `npm audit fix`
node_modules/express/node_modules/body-parser

6 vulnerabilities (1 moderate, 5 high)

To address all issues, run:
  npm audit fix

github-actions[bot] avatar Nov 27 '25 09:11 github-actions[bot]

# npm audit report

@angular/common  20.0.0-next.0 - 20.3.13
Severity: high
Angular is Vulnerable to XSRF Token Leakage via Protocol-Relative URLs in Angular HTTP Client - https://github.com/advisories/GHSA-58c5-g7wp-6w37
fix available via `npm audit fix`
node_modules/@angular/common
  @angular/forms  4.4.0-RC.0 - 4.4.0 || 20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/forms
  @angular/platform-browser  20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  node_modules/@angular/platform-browser
  @angular/platform-browser-dynamic  20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/platform-browser-dynamic
  @angular/router  10.0.0-next.0 - 10.0.0-rc.1 || 20.0.0-next.0 - 20.3.13
  Depends on vulnerable versions of @angular/common
  Depends on vulnerable versions of @angular/platform-browser
  node_modules/@angular/router

body-parser  2.2.0
Severity: moderate
body-parser is vulnerable to denial of service when url encoding is used - https://github.com/advisories/GHSA-wqch-xfxh-vrr4
fix available via `npm audit fix`
node_modules/express/node_modules/body-parser

6 vulnerabilities (1 moderate, 5 high)

To address all issues, run:
  npm audit fix

github-actions[bot] avatar Nov 27 '25 12:11 github-actions[bot]

The npm audit check is still failing because of existing vulnerabilities in Angular (@angular/common, @angular/forms, @angular/router, etc.). I ran npm audit fix --package-lock-only, but it didn’t change anything.

I guess fixing this would require updating Angular dependencies in package.json (e.g. @angular/common, @angular/forms, @angular/router, @angular/platform-browser, ...), which seems, for me, out of scope for this feature. Could you confirm how you want to handle this?

Thanks

LuffyNoNika avatar Nov 27 '25 12:11 LuffyNoNika

Yes, that is okay, we will check the np, audit problems with a different ticket.

gluafamichl avatar Nov 27 '25 15:11 gluafamichl