fleur

fleur copied to clipboard

fleur segfaults on insertion using corrupted bloomfilter files

1

fleur segfauts on insertion with the following corrupted (gzipped) bloomfilter files: [crash0_insert.bin.gz](https://github.com/hashlookup/fleur/files/9207722/crash0_insert.bin.gz) [crash1_insert.bin.gz](https://github.com/hashlookup/fleur/files/9207723/crash1_insert.bin.gz) The command used to reproduce the crashes is ```echo bla | ./fleurcli -c insert crash0_insert.bin``` Valgind output:...

wllm-rbnt

Memory allocation issues when using corrupted bloomfilter files

3

fleur allocates large amounts of memory when using corrupted bloomfilter files on insertion. Cfr attached gzipped files: [hang0_insert.bin.gz](https://github.com/hashlookup/fleur/files/9207520/hang0_insert.bin.gz) [hang1_insert.bin.gz](https://github.com/hashlookup/fleur/files/9207521/hang1_insert.bin.gz) [hang2_insert.bin.gz](https://github.com/hashlookup/fleur/files/9207522/hang2_insert.bin.gz) This can be tested using the following command: ```echo bla...

wllm-rbnt

> Could be faster still if it didn't calloc/free a "Fingerprint" buffer each time you add or query an entry. Since its individual BloomFilters are not thread-safe anyway, it could...

gallypette

> using good prefix, or even suffix for C library is a must, and come up with something unique (and "fleur" is kind of cool), probably good idea to prefix...

gallypette

check optargs copy in fleurcli

2

> There is also strange code like this loop [https://github.com/hashlookup/fleur/blob/4ee2644a850381d928a...](https://github.com/hashlookup/fleur/blob/4ee2644a850381d928ad86fce8b2357f21102eee/fleurcli/fleurcli.c#L102) that jumped into my eye. > > Oh and btw I believe bloom_path can cause memory safety issues because it...

gallypette

- allocate only once, - no static > The usage of `static` variables makes the BloomFilter code unnecessarily dangerous to use when multiple threads are used even if every thread...

gallypette

- get back the number of matches, - get back the number of inserts.

gallypette