hash icon indicating copy to clipboard operation
hash copied to clipboard

Avoid copying data when converting ArrayData from JS to Rust

Open leudz opened this issue 3 years ago • 0 comments

🌟 What is the purpose of this PR?

When building ArrayData on the Rust side we copy all data from Javascript. Rust and Javascript don't have the same expectation regarding what the array contains. But sometimes they line up and we can skip the copy and just map the array.

🔗 Related links

🚫 Blocked by

🔍 What does this change?

  • Update the arrow Rust library from v10 to v13
  • Map array data when possible to avoid copying the data from Javascript to Rust

📜 Does this require a change to the docs?

No

🐾 Next steps

🛡 What tests cover this?

  • All tests involving Arrow and the Javascript runner

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try cargo test
  3. Confirm that all tests pass

leudz avatar May 12 '22 13:05 leudz