hash icon indicating copy to clipboard operation
hash copied to clipboard

Replace simple Rust behaviors with JS for example simulation to be tested

Open TimDiekmann opened this issue 3 years ago • 4 comments

🌟 What is the purpose of this PR?

We currently don't support Rust behaviors yet, in order to test a few more simulations, we should replace very simple Rust behaviors with JS: age.rs and move_in_direction.rs

Doing this enables two additional examples to be run and discovered two new bugs!

🚫 Blocked by

🐾 Next steps

Investigate the new bugs and fix them

🔍 What does this change?

Replaces the age.rs and move_in_direction.rs with simple JavaScript behaviors to be tested at examples.

🔗 Related links

TimDiekmann avatar Mar 24 '22 13:03 TimDiekmann

The PR fails at the CI with an error, which is very very likely because arrow-rs have different expectations than JavaScript's arrow implementation. I marked this as blocked by Move to Arrow2 (internal).

TimDiekmann avatar Mar 29 '22 09:03 TimDiekmann

Weird, the test job is failing while the bench job is passing 🤔

TimDiekmann avatar Jun 20 '22 22:06 TimDiekmann

I triggered a new run. Maybe it was a very unlucky spurious failure (somehow the test was terminated by SIGKILL). I will investigate this later.

TimDiekmann avatar Jun 20 '22 22:06 TimDiekmann

It appears that we have a memory leak in hEngine and this is accumulating when running multiple tests. This PR is ready to be merged but my worry is, that we will have some spurious failures due to the leak when running the CI on Pull Requests. As I don't see many benefits in merging this PR right away, I will hold back merging until the leak is fixed.

Asana Task (internal)

TimDiekmann avatar Jun 21 '22 09:06 TimDiekmann

To revisit as part of this task (internal link)

vilkinsons avatar Nov 15 '22 14:11 vilkinsons