hedera-sdk-java icon indicating copy to clipboard operation
hedera-sdk-java copied to clipboard

feat (HIP-540): Change Or Remove Existing Keys From A Token

Open thenswan opened this issue 1 year ago • 2 comments

Description: This PR implements HIP-540.

Side-effects of this PR:

  • protobuf update

Related issue(s):

Fixes #1506

Notes for reviewer:

  • temp gradle and ci config and client-config-with-operator update (revert before making ready for review)

Checklist

  • [X] Documented (Code comments, README, etc.)
  • [X] Tested (unit, integration, etc.)

thenswan avatar May 08 '24 07:05 thenswan

I don't like following output in the example in Supply Key (after removing) (would like to raise the discussion regarding possible options):

> Task :examples:ChangeRemoveTokenKeys.main()
Admin Key (before removing):302a300506032b65700321005b17021ae20cadc00527132157a8173026a7a473386809966b69edd3a98b6bbf
Supply Key (before removing):302a300506032b6570032100ced5202f0f42e6f6aa383cc46bc40566f5b8ad5e576d8ec462f48d47023a519a
Wipe Key (before removing):302a300506032b657003210081252ba6828f4711723a7184c64e7341f31791a2ce14858ad1036521f431235a
Wipe Key (after removing):null
Admin Key (after removing):null
Supply Key (after removing):302a300506032b65700321000000000000000000000000000000000000000000000000000000000000000000

thenswan avatar May 14 '24 08:05 thenswan

I don't like following output in the example in Supply Key (after removing) (would like to raise the discussion regarding possible options):

> Task :examples:ChangeRemoveTokenKeys.main()
Admin Key (before removing):302a300506032b65700321005b17021ae20cadc00527132157a8173026a7a473386809966b69edd3a98b6bbf
Supply Key (before removing):302a300506032b6570032100ced5202f0f42e6f6aa383cc46bc40566f5b8ad5e576d8ec462f48d47023a519a
Wipe Key (before removing):302a300506032b657003210081252ba6828f4711723a7184c64e7341f31791a2ce14858ad1036521f431235a
Wipe Key (after removing):null
Admin Key (after removing):null
Supply Key (after removing):302a300506032b65700321000000000000000000000000000000000000000000000000000000000000000000

Addressed.

thenswan avatar May 15 '24 07:05 thenswan

Quality Gate Failed Quality Gate failed

Failed conditions
69.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 12 '24 10:06 sonarqubecloud[bot]