redmine_code_review icon indicating copy to clipboard operation
redmine_code_review copied to clipboard
verified publisher icon haru

More refactoring

Open jkraemer opened this issue 7 years ago • 4 comments

Few refactorings in controllers / models. Likely I'll be adding more here soon.

  • There is no point in using unloadable in Redmine plugins nowadays.
  • require_dependency should only be used when necessary
  • made few parts of the code more Ruby-like and thus more readable (imho)

jkraemer avatar Mar 12 '18 05:03 jkraemer

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls avatar Mar 12 '18 06:03 coveralls

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls avatar Mar 12 '18 06:03 coveralls

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls avatar Mar 12 '18 06:03 coveralls

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls avatar Mar 12 '18 06:03 coveralls