redmine_code_review icon indicating copy to clipboard operation
redmine_code_review copied to clipboard
verified publisher icon haru

View refactorings

Open jkraemer opened this issue 7 years ago • 1 comments

This PR addresses a few potential security problems due to usage of raw and lack of javascript escaping:

  • replaces all usages of the raw helper in views with safer alternatives.
  • introduces Javascript-escaping via the j helper.

Also some general refactorings:

  • extracted the progress_for_changeset helper method
  • re-used the existing show_assignments helper in another place
  • removed controller and request context arguments as these do not needed to be passed around like this

jkraemer avatar Mar 12 '18 04:03 jkraemer

Coverage Status

Coverage decreased (-0.1%) to 87.613% when pulling 40143ef6ae6456fab65cfe80a1173f3594a608ce on planio-gmbh:view-refactorings into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls avatar Mar 12 '18 04:03 coveralls