gitlab.nvim icon indicating copy to clipboard operation
gitlab.nvim copied to clipboard

chore(docs): add keybindings in README for which-key users

Open chardskarth opened this issue 1 year ago • 3 comments

I added these for better DX, because I don't think it's possible for devs to remember all these available feature. With which-key, the user should be able to see what each keybinding does.


This plugin is awesome, and very helpful.

I sure hope a lot of people will contribute to your project @harrisoncramer !

chardskarth avatar Jul 30 '24 13:07 chardskarth

Hey thank you very much for the MR! We are actually in the process of pulling these keybindings into the plugin itself, (see #331) so it probably makes sense for us to get that merged first, and then you can work from there? Some of the keybindings will change.

Thanks for the kind words!

harrisoncramer avatar Jul 31 '24 01:07 harrisoncramer

Marking this as draft until #331 gets done. Thanks!

chardskarth avatar Jul 31 '24 05:07 chardskarth

Hey @chardskarth I've merged in the keybindings changes into develop, if you want to give a quick look them now and adjust this, they should be ready.

We can merge and ship this them both to main at the same time. Thanks!

harrisoncramer avatar Aug 08 '24 12:08 harrisoncramer

Given some thought. I think the default keybinding works best. I think it's enough that the user can opt out from the default bindings. And if the user has that skill, they probably can spin up their own keybinding anyway.

Thanks for taking time on this. Closing now.

chardskarth avatar Aug 14 '24 16:08 chardskarth