gitlab.nvim icon indicating copy to clipboard operation
gitlab.nvim copied to clipboard

Feat: Make Remote Configurable

Open lewisdiamond opened this issue 1 year ago • 3 comments

Prerequsities

  • [x] I'm on the latest version of the plugin
  • [x] I've installed the required dependencies
  • [x] I've run :h gitlab.nvim.troubleshooting and followed the steps there

Setup Configuration and Environment

N/A

Bug Description

Hard coded origin

While some people may use the gitlab instance as the origin remote, there can be multiple remotes and can be named anything, not just origin. The remote needs to be found from the configured gitlab url by matching with the list of remotes.

Reproduction Steps

N/A

Screenshots

If applicable, add screenshots to help explain your problem.

lewisdiamond avatar Jun 11 '24 19:06 lewisdiamond

While this isn't implemented it would be great if there was a note in the documentation and especially the README of the project about origin being hard coded.

tboehler1 avatar Jun 20 '24 07:06 tboehler1

I've added a note about "origin" in #320, so it's now in branch "develop", but maybe it should be in "main" as that is probably what most people are using. So depending on whether/when @harrisoncramer plans to implement this feature (#314) it could make sense to also merge #320 to "main" for now.

jakubbortlik avatar Jun 24 '24 04:06 jakubbortlik

I marked this as a good first issue, since the change would be straightforward to add (adding a setting to the configuration function and then passing it as a parameter to the Go server), and I'd like to encourage others to implement new features that they want; I'm not opposed to adding it but wanted to give someone else the opportunity to contribute!

harrisoncramer avatar Jun 26 '24 14:06 harrisoncramer

@lewisdiamond or @tboehler1 I've implemented this in https://github.com/harrisoncramer/gitlab.nvim/pull/348

Does this branch work for you?

harrisoncramer avatar Aug 18 '24 03:08 harrisoncramer