hardcore-sushi
ImageViewer.kt
I wasn't happy with the loading time of thumbnails. So I changed the code to cache thumbnails in the volume. Images are reduced, videos not. Can you please review and add this?
It doesn't compile for me. As I understand it, you store the images in plain text on disk. I don't think users will appreciate that.
The idea is actually to store the thumbnails in the encrypted volume as well. I think the path probably isn't going into the volume correctly. The number of parentheses may also be incorrect. I guess you know best how it can work.
Hardcore Sushi @.***> schrieb am Mi., 21. Juni 2023, 16:15:
It doesn't compile for me. As I understand it, you store the images in plain text on disk. I don't think users will appreciate that.
— Reply to this email directly, view it on GitHub https://github.com/hardcore-sushi/DroidFS/pull/215#issuecomment-1600919023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVGKFXUYEEDTJNE235Q2XDLXML6WNANCNFSM6AAAAAAZND6FKE . You are receiving this because you authored the thread.Message ID: @.***>
That's not what your code does. Still, I don't think using a hardcoded folder in the volume is a good idea. What would happen if the volume is read-only?
Maybe in the long run you could use a new setting option with a path variable. In the short term it seems acceptable. I've never heard that there can be read-only FS in DroidFS. Could be because I still have Android 11 and that you can assign read-only permissions with Android 13. In such cases, no attempt should be made to save a thumbnail.
Hardcore Sushi @.***> schrieb am Do., 22. Juni 2023, 11:26:
That's not what your code does. Still, I don't think using a hardcoded folder in the volume is a good idea. What would happen if the volume is read-only?
— Reply to this email directly, view it on GitHub https://github.com/hardcore-sushi/DroidFS/pull/215#issuecomment-1602310923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVGKFXSWNR7QSBCG5LRFXXLXMQFWDANCNFSM6AAAAAAZND6FKE . You are receiving this because you authored the thread.Message ID: @.***>
The DroidFS goal is to be compatible with desktop softwares. Users should be able to synchronize volumes between their devices and open them everywhere. We don't want DroidFS to automatically store additional data in volumes, and therefore modify local copies.