wpf-notifyicon icon indicating copy to clipboard operation
wpf-notifyicon copied to clipboard

Migrated the license to MIT

Open Lakritzator opened this issue 3 years ago • 10 comments

Also removed .NET 5.0 support as this is EOL.

Closes #56

Lakritzator avatar Sep 11 '22 18:09 Lakritzator

Created this for #56

Lakritzator avatar Sep 11 '22 18:09 Lakritzator

I also bumped up the version to 2.0.x as I consider a license change a potential breaking / major change. Look at this to see how the file header was changed: https://github.com/hardcodet/wpf-notifyicon/pull/84/files#diff-ffd2fa4db00e15fe03e88dff6cc543d6be7000eeb99c57000dbfbdd44e90d889

Lakritzator avatar Sep 11 '22 19:09 Lakritzator

Oh, forgot, I also changed the namespace to use file scoped namespace. I probably regret that change, not for the change itself but as some PR will no longer merge without manual work. 🙄

I already regretted it, so I undid the change.

Lakritzator avatar Sep 11 '22 19:09 Lakritzator

It's been a while, what's the status of this PR? I also see that this branch has conflicts with the base.

trungnt2910 avatar Sep 25 '22 00:09 trungnt2910

Life came in between, just wait.

Lakritzator avatar Sep 25 '22 12:09 Lakritzator

Hey @punker76 & @hardcodet can you take a look at this, so we can merge it?

Lakritzator avatar Oct 09 '22 18:10 Lakritzator

Hey @Lakritzator and @hardcodet

I saw the discussion about this in #56. This is a really great project, and pulling in this license change would definitely make my life easier. Any chance of that happening? Thanks, and good luck!

tstavropoulos avatar May 17 '23 13:05 tstavropoulos

Any news?

Linx-ESP avatar Jan 04 '24 20:01 Linx-ESP

I'm a bit interested in this license change as well due CPOL not being on a corporate's acceptable use list. Are there any stoppers from this being merged? @hardcodet @punker76

kjean667 avatar Jun 11 '24 14:06 kjean667

@Lakritzator @hardcodet LGTM

punker76 avatar Jun 11 '24 14:06 punker76