hanami
GS Guide: Hanami 1.2 test count is different
Right before the section in the GS guide called "Building Forms To Create Records", there's some test output shown:
9 runs, 16 assertions, 0 failures, 0 errors, 0 skips
This test output has changed in v1.2 to:
12 runs, 20 assertions, 0 failures, 0 errors, 0 skips
I guess there have been some new tests added in the interim?
I am submitting this as an issue and not a PR because I couldn't find a 1.2-specific getting started guide at the moment.
:+1: Thanks! With #429 we're working on converting the Getting Started guide to use RSpec instead of MiniTest. In that process, we're going through and updating the test outputs, since they look different with RSpec, too.
That should be live before 1.2.0 (It's really 100% my fault if it's not...).
This is likely the cause: https://github.com/hanami/hanami/pull/860 . Before we had a skip, but now there's a real expectation being made, which causes this discrepancy.
That PR was also shipped in 1.1.1, which was released yesterday. If you (or anyone else) wants to open a PR with this change against the 1.1 guides, that'd be great. 🌸
